Matthew Brandly brandly

Organizations

@Fetchnotes @staticshowdown
brandly created branch master at brandly/2048
brandly created repository brandly/2048
@brandly

Glad you got it working!

brandly deleted branch more-urls at brandly/angular-youtube-embed
@brandly
@brandly
question about getIdFromURL method
1 commit with 10 additions and 0 deletions
brandly commented on pull request brandly/angular-youtube-embed#57
@brandly

i added those URLs to the tests. getIdFromURL appears to already be handling them, but i'm glad we have the tests to prove it now thanks!

@brandly

that should work fine. you could have an array of objects like $scope.videos = [{ id: 'zFXpNT-Tse0', vars: { }, ....] and then just <div ng-repeat=…

brandly starred jsemu/gba
@brandly
youtube.player.playing event doesn't fire on Firefox
@brandly

glad it's working!

@brandly

on firefox v38.0.1, i see those errors you mentioned, but they're coming from inside YouTube's official library, which i have no control of in the …

@brandly

could you try this out? http://plnkr.co/edit/HGlRcsT2okJ6BiYUjpdX?p=preview click play on the video and let me know if you see playing!!! in your c…

@brandly

hey! in case you didn't see #52, as of v1.0.2, things should be working again. changes in the underlying YouTube library broke functionality. relyi…

@brandly

thanks for the help! #46 is probably the true goal but, for now, things are working again :star2: v1.0.2

@brandly
  • @brandly 7c52ee6
    v1.0.2, fix dynamic videos
brandly deleted branch dont-check-player-d at brandly/angular-youtube-embed
@brandly
@brandly
remove player.d check, fix dynamic video functionality
2 commits with 24 additions and 2 deletions
@brandly
Player is never destroyed
@brandly
Change the scr of video dynamically
brandly commented on pull request brandly/angular-youtube-embed#53
@brandly

this definitely looks like a regression against #16. however, if this does cause problems, checking for player.d is a bad solution. the d appears t…

@brandly
  • @brandly ff4bbf2
    remove check for player.d before destroying player