Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python <2.7 from supported versions #24

Closed
wants to merge 1 commit into from
Closed

Remove Python <2.7 from supported versions #24

wants to merge 1 commit into from

Conversation

and-semakin
Copy link

@and-semakin and-semakin commented May 20, 2020

Python interpreters 2.6 and below are not supported because they don't have print() function.
We can fix support for Python 2.6 adding from __future__ import print_function import, but I don't think that there is a reason to support such an old version. Older versions (2.5 and below) are completely incompatible with Python 3.

Commit that breaks Python 2.6 compatibility: a276a29

Python interpreters 2.6 and below are not supported because
they don't have `print()` function.
@brandon-rhodes
Copy link
Owner

The project setup.py explicitly declares support for Python 2.6, and I have not heard reports of the library failing on that Python version, nor on any earlier Python version. What exception did you see when you tried testing it?

@and-semakin
Copy link
Author

and-semakin commented May 20, 2020

Sorry, I created the PR without actually checking the hypothesis. I've checked all the versions until Python 2.3 and now I understand why it works.

@brandon-rhodes
Copy link
Owner

Thank you for testing it! The print(only_one_single_value) trick is very limited, but in the early Python 3 days it proved quite helpful for folks targeting 2.6, so I went ahead and used it here. I figured, for so simple a library, why not keep it compatible with every Python version for which logging existed?

@and-semakin
Copy link
Author

Makes sense. Thanks for the library, by the way!

@and-semakin and-semakin deleted the fix-compatible-versions branch May 21, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants