Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Nov 9, 2009
  1. Natalie Weizenbaum

    Bump VERSION to 2.2.13.

    nex3 authored
  2. Natalie Weizenbaum
Commits on Nov 8, 2009
  1. Natalie Weizenbaum

    [Haml] Add support for a workaround for fake ASCII input strings.

    nex3 authored
    Closes gh-3
    
    This is a complicated issue, but I'll do my best to explain it here.
    By default, Haml encodes its templates as Encoding.default_internal,
    which is usually UTF-8. This means that strings printed to the
    template should be either UTF-8 or UTF-8-compatible ASCII. So far, all
    well and good.
    
    Now, it's possible to have strings that are marked as ASCII-8bit, but
    which aren't UTF-8 compatible. This includes valid UTF-8 strings that
    are forced into an ASCII-8bit encoding. If one of these strings is
    concatenated to a UTF-8 string, Ruby says "I don't know what to do
    with these non-ASCII characters!" and throws an encoding error. I call
    this sort of string "fake ASCII."
    
    This is what was happening in the referenced GitHub issue (or at least
    in the sample app Adam Salter created at
    http://github.com/adamsalter/test-project/tree/haml_utf8). The
    template was UTF-8 encoded, and it was being passed a fake ASCII
    string, marked as ASCII-8bit but with UTF-8 byte sequences in it, and
    it was choking.
    
    The issue now becomes: where is this fake ASCII string coming from?
    From the database. The database drivers used by Rails aren't Ruby 1.9
    compatible. Despite storing UTF-8 strings in the database, the drivers
    return fake ASCII strings.
    
    The best solution to this is clearly to fix the database drivers, but
    that will probably take some time. One stop-gap would be to call
    `force_encoding("utf-8")` on all the database values somewhere, which
    is still a little annoying. Finally, the solution provided in this
    commit is to set `:encoding => "ascii-8bit"` for Haml. This makes the
    Haml template itself fake ASCII, which is wrong but will help prevent
    encoding errors.
  2. Natalie Weizenbaum
Commits on Nov 6, 2009
  1. Natalie Weizenbaum

    Bump VERSION to 2.2.12.

    nex3 authored
  2. Natalie Weizenbaum

    [Sass] Fix a stupid bug and make the Rails plugin work.

    nex3 authored
    How embarassing.
    
    Closes gh-56
  3. Natalie Weizenbaum

    Bump VERSION to 2.2.11.

    nex3 authored
  4. Natalie Weizenbaum

    [Sass] Use proper callback mechanisms to register Sass on Rails 3.0, …

    nex3 authored
    …rather than monkeypatching.
  5. Natalie Weizenbaum
  6. Natalie Weizenbaum

    Get rid of the 'Edge Rails Compatibility' changelog sections, since t…

    nex3 authored
    …here's only one such change now.
  7. Natalie Weizenbaum

    Merge commit 'origin/stable' into stable

    nex3 authored
    Conflicts:
    	doc-src/SASS_CHANGELOG.md
  8. Natalie Weizenbaum

    [Haml] Abstract away RAILS_ROOT.

    nex3 authored
    Closes gh-48
  9. Natalie Weizenbaum

    Revert "[Haml] Support concatenating multiple CSS-syntax ids using _."

    nex3 authored
    This reverts commit 5aa2cd6.
    
    Conflicts:
    
    	doc-src/HAML_CHANGELOG.md
  10. Natalie Weizenbaum
Commits on Nov 5, 2009
  1. Natalie Weizenbaum
  2. Natalie Weizenbaum
Commits on Nov 4, 2009
  1. Natalie Weizenbaum
  2. Natalie Weizenbaum

    Merge commit 'origin/stable' into stable

    nex3 authored
    Conflicts:
    	doc-src/HAML_CHANGELOG.md
  3. Natalie Weizenbaum

    [Haml] Fix an error line-numbering bug with =.

    nex3 authored
    This is a bad solution, as it breaks up merged text unnecessarily.
    This breaking up may not be fixable
    without some refactoring of the precompiler, though,
    so that's being pushed off to the master branch
    to be released as part of 2.4.
  4. Natalie Weizenbaum
Commits on Nov 2, 2009
  1. Natalie Weizenbaum
  2. Natalie Weizenbaum
Commits on Oct 31, 2009
  1. Natalie Weizenbaum
  2. Natalie Weizenbaum
  3. Natalie Weizenbaum

    [Sass] Default to interpreting valueless properties as pseudo-classes…

    nex3 authored
    … if :property_syntax is :new.
  4. Natalie Weizenbaum
Commits on Oct 30, 2009
  1. Natalie Weizenbaum
Commits on Oct 29, 2009
  1. Natalie Weizenbaum

    Bump VERSION to 2.2.10.

    nex3 authored
  2. Natalie Weizenbaum
  3. Natalie Weizenbaum

    [Haml] Mark the return value of the Haml rendering method as HTML saf…

    nex3 authored
    …e if XSS protection is enabled.
    
    Closes gh-50
  4. Natalie Weizenbaum
  5. Natalie Weizenbaum

    [Haml] Fix the reference w.r.t. exactly how pres and textareas auto-p…

    nex3 authored
    …reserve.
    
    It's not actually the case that they preserve nested content;
    this would be very difficult to do in a general way.
    They actually only generate content given with =.
    
    Closes gh-46
Commits on Oct 25, 2009
  1. Natalie Weizenbaum
  2. Natalie Weizenbaum
Commits on Oct 23, 2009
  1. Natalie Weizenbaum
Something went wrong with that request. Please try again.