Skip to content

Update to Celluloid 0.17 - #126

Merged
brandonhilkert merged 2 commits into
brandonhilkert:masterfrom
donaldpiret:master
Oct 16, 2015
Merged

brandonhilkert merged 2 commits into
brandonhilkert:masterfrom
donaldpiret:master

Conversation

@donaldpiret

Copy link
Copy Markdown
Contributor

Not sure if this is 100% correct. Couldn't really figure out what the CellProxy was doing. Would appreciate if you could have a look.

@brandonhilkert

Copy link
Copy Markdown
Owner

Hey Donald! Thanks for the this. Give me a little bit to look over and understand what's going on with new Celluloid and I'll get back to you. Thanks again!

@eileencodes

Copy link
Copy Markdown

When you merge this, it needs to go to celluloid 0.17.2, there's apparently a memory leak in anything below 0.17.2 although the repo doesn't confirm this in the changelog. I read about it here sidekiq/sidekiq#2582

@brandonhilkert

Copy link
Copy Markdown
Owner

I saw a similar Tweet from Mike yesterday. Thanks for the heads up!


Build a Ruby Gem is available!
http://brandonhilkert.com/books/build-a-ruby-gem/?utm_source=gmail-sig&utm_medium=email&utm_campaign=gmail

http://brandonhilkert.com

On Fri, Oct 2, 2015 at 8:58 AM, Eileen M. Uchitelle <
notifications@github.com> wrote:

When you merge this, it needs to go to celluloid 0.17.2, there's
apparently a memory leak in anything below 0.17.2 although the repo doesn't
confirm this in the changelog. I read about it here sidekiq/sidekiq#2582
sidekiq/sidekiq#2582

—
Reply to this email directly or view it on GitHub
#126 (comment)
.

Comment thread sucker_punch.gemspec

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this "~> 0.17.2"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thank you for handling that! Sorry I couldn't take care of it earlier. Ended up having a very busy last couple of days.

brandonhilkert added a commit that referenced this pull request Oct 16, 2015
@brandonhilkert
brandonhilkert merged commit faad882 into brandonhilkert:master Oct 16, 2015
@brandonhilkert

Copy link
Copy Markdown
Owner

Release version 1.6.0 today as a result of your work. Thanks for the help here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants