/slackbot-workout

Add support for office hours #20

Merged
merged 2 commits into from Oct 8, 2015
+45 −12

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@slinlee @brandonshin
@slinlee

slinlee commented Oct 6, 2015

Set the times the bot should be running in config.json.

Right now this is very simple and only supports whole hours and doesn't
check if the last challenge of the day is outside office hours.

Fixes #17
slee Add support for office hours 
Set the times the bot should be running in config.json.

Right now this is very simple and only supports whole hours and doesn't
check if the last challenge of the day is outside office hours.
 e849a71

slinlee referenced this pull request Oct 6, 2015

Closed

Office hours? #17

@brandonshin brandonshin commented on the diff Oct 7, 2015

View full changes
default.json
@@ -3,6 +3,11 @@
"channelName": "general",
"channelId": "channelIdHere",
+ "officeHours": {
@brandonshin

brandonshin Oct 7, 2015

Owner

I'd add a on Boolean property that defaults to "off", set the default begin/end values to 9, 17 respectively (since that is the understood 9-5 work hours).

It'd be an easy additional check to see if the bot should respect the designated office hours or not. Otherwise it looks good.

@slinlee

slinlee Oct 7, 2015

Done!
slee Toggle officehours feature with boolean 
Set in config.json, and is is off by default.

This also sets the default office hours to be 9 to 5pm.
 b18d80c
@brandonshin
Owner

brandonshin commented Oct 8, 2015

looks good @slinlee 👌pulling it in! Thanks!

brandonshin merged commit 19c270f into brandonshin:master Oct 8, 2015

slinlee deleted the slinlee:officehours branch Oct 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment