Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate ★s with non-breaking spaces #60

Merged
merged 1 commit into from Sep 15, 2016
Merged

Conversation

@jswrenn
Copy link
Contributor

jswrenn commented Sep 15, 2016

On narrow displays, the browser sometimes inserts line-breaks between the stars of the star-ratings on the Reading page:
broken-stars
At first glance, very well reviewed books may appear to have been received abysmally. This commit separates the stars using non-breaking spaces, instead of normal spaces.

Copy link
Owner

brandur left a comment

Hah, I love it! This didn't even occur to me at all, but yeah that's certainly problematic. Thanks!

@brandur brandur merged commit ac4a3b8 into brandur:master Sep 15, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
brandur added a commit that referenced this pull request Sep 2, 2018
Separate ★s with non-breaking spaces

Former-commit-id: ac4a3b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.