Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache wallet endpoint #2386

Closed
wants to merge 4 commits into from

Conversation

@corymcdonald
Copy link
Contributor

corymcdonald commented Nov 15, 2019

Cache wallet endpoint

Features

I want this caching to eventually go down from an hour to something more reasonable like 5-10 minutes. For now due to the instability of the servers we're going to set it for an hour.

  • When Eyeshade is having problem throw an error instead of returning :unavailable
  • Cache service calls for an hour which make up the Wallet object.
@yachtcaptain23

This comment has been minimized.

Copy link
Contributor

yachtcaptain23 commented Nov 15, 2019

Closes #1719

@corymcdonald corymcdonald temporarily deployed to bat-publishers-dev Nov 15, 2019 Inactive
Copy link
Contributor

yachtcaptain23 left a comment

Tested on dev. Would prefer moving to a separate table but I don't see a point at the moment.

Copy link
Contributor

yachtcaptain23 left a comment

Spoke with eV, let's not cache the balance endpoint.

I would prefer a separate table as a select * from publishers would take longer if each entry in transactions_cache column was a KB.

@corymcdonald corymcdonald self-assigned this Nov 20, 2019
@yachtcaptain23

This comment has been minimized.

Copy link
Contributor

yachtcaptain23 commented Nov 25, 2019

@corymcdonald will expand this PR to cover more transactions and store in a separate table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.