Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat wildcard and separator wildcards differently (* and ^) #150

Closed
bbondy opened this Issue Dec 12, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@bbondy
Copy link
Member

bbondy commented Dec 12, 2018

Currently we treat both * and ^ the same.
I believe this is what uBlock does.

But we recently discovered there are rules on the Japanese list that don't work properly because we don't follow ABP rules.

Let's follow ABP rules instead as per:
https://adblockplus.org/filters#separators

iefremov added a commit that referenced this issue Dec 13, 2018

Fix incorrect handling of filters beginning with circumflex (^).
Basically reworked the string matching function, making it shorter
and simpler and added some tests.

Fix #150

iefremov added a commit that referenced this issue Dec 13, 2018

Fix incorrect handling of filters beginning with circumflex (^).
Basically reworked the string matching function, making it shorter
and simpler and added some tests.

Fix #150

@bbondy bbondy closed this in #152 Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.