This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor filter_list slightly to appease Chromium style checker plugin #102
+39
−13
Conversation
The Chromium Style Checker plugin was complaining about the complexity of the inlined constructors when I started referencing the regional ad block filter list on Windows. More details here: https://www.chromium.org/developers/coding-style/chromium-style-checker-errors
|
Auditor: @bbondy |
|
You'll have to update ref to use the new one on master or also PR and patch the 3.x branch btw. Since we aren't launched yet I'd be fine with going to v4 but you may want to keep it on v3 for now so you can figure out how updates will be handled. |
|
Thanks for pointing that out! Created a new PR against 3.x for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emerick commentedMay 25, 2018
The Chromium Style Checker plugin was complaining about the complexity
of the inlined constructors when I started referencing the regional ad
block filter list on Windows.
More details here:
https://www.chromium.org/developers/coding-style/chromium-style-checker-errors