This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd test and fix for passing an invalid serialized dat info to client deserialize #153
+30
−3
Conversation
….deserialize
|
Does this also fail if you just use C++ directly? Wondering if the fix should be in ad_block_client.cc instead. |
|
where was this failing before exactly? We don't have exceptions in the main lib |
|
its just an assert, not an exception
|
|
@bbondy just a ping on this. Does it look good? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pes10k commentedDec 14, 2018
Passing an invalid string (something that wasn't generated from
client.serialize) toclient.deserializecrashes node.This PR includes a test and fix