Skip to content
This repository has been archived by the owner. It is now read-only.

/ ad-block Archived

Fixed an issue with C++ sample in README.md #163

Merged
merged 2 commits into from Feb 1, 2019
Merged

Fixed an issue with C++ sample in README.md #163

merged 2 commits into from Feb 1, 2019
+1 −2

Conversation

@ali-idrizi
Copy link
Contributor

ali-idrizi commented Jan 23, 2019

The first argument of AdBlockClient::serialize() is int*. In the sample code an int is passed instead.
ali-idrizi added 2 commits Jan 23, 2019
@ali-idrizi
Fix an issue with C++ sample
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
28338fa
@ali-idrizi
remove duplicate import
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
363734c
@bbondy
bbondy approved these changes Feb 1, 2019
View changes
Copy link
Member

bbondy left a comment

Thanks!
@bbondy bbondy merged commit 9a29073 into brave:master Feb 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbondy bbondy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ali-idrizi @bbondy
You can’t perform that action at this time.