This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFind matching filters should check 3p context #167
Merged
+42
−6
Conversation
|
lgtm, and thanks for choosing that as the additional new test :) |
|
np this was the new test that would fail with the old code btw: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bbondy commentedJan 29, 2019
Originally ad-block clients needed to calculate if the context option was 3p or 1p by itself and tell the ad-block lib that. Later we moved that to matches, but we never checked it in find matching filters.
We now automaticlaly calculate it for clients using this function:
Fix #166