This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse upstream uBlock unbreak list directly (fixes brave/adblock-lists#52) #183
Conversation
fmarier
added a commit
to fmarier/adblock-lists
that referenced
this pull request
Feb 27, 2019
In brave/ad-block#183 we started fetching the upstream list directly.
fmarier
added a commit
to fmarier/adblock-lists
that referenced
this pull request
Feb 27, 2019
In brave/ad-block#183 we started fetching the upstream list directly.
fmarier
added a commit
to fmarier/adblock-lists
that referenced
this pull request
Mar 6, 2019
In brave/ad-block#183 we started fetching the upstream list directly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fmarier commentedFeb 27, 2019
This fixes brave/adblock-lists#52.
I have build the
datfile with this change and didn't see any errors in this list. I also tested the generateddatfile in Beta and saw ads blocked on CNN, as expected.If this is accepted, I'll file another PR to remove
ublock-unbreak.txtfrom thebrave/adblock-listsrepo.