This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly determine third-party when needed #188
Merged
Conversation
|
LGTM |
bbondy
added a commit
that referenced
this pull request
Mar 1, 2019
Only determine third-party when needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bbondy commentedMar 1, 2019
•
edited
See also:
brave/brave-core#1813
See also:
brave/brave-browser#3535
Basically this will only set the
FOThirdPartyandFONotThirdPartyflags internally if we didn't specify them when callingmatch.This is to get past a problem where the library doesn't calculate it correctly with an easy fix in brave-core.