This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for conditional matching filters based on tags #192
Conversation
|
LGTM, just had one question about the buffer management (which could be totally innocuous, just wasn't sure). |
| @@ -1472,6 +1495,15 @@ int serializeFilters(char * buffer, size_t bufferSizeAvail, | |||
| } | |||
| bufferSize++; | |||
|
|
|||
| if (f->tagLen > 0) { | |||
| if (buffer) { | |||
| buffer[bufferSize] = '#'; | |||
This comment has been minimized.
This comment has been minimized.
emerick
Mar 3, 2019
Contributor
Is it safe to assume the buffer has the space available for this additional data? Wasn't quite sure how that side of things works.
This comment has been minimized.
This comment has been minimized.
bbondy
Mar 3, 2019
Author
Member
Yep how it works is it calls the function 2 times. The first with nullptr buffer to get the size. The second it specifies a buffer of that size.
This comment has been minimized.
This comment has been minimized.
|
there are risky changes with memory management. I hope unit tests covered it. Looks good otherwise. |
bbondy
force-pushed the
condition-tagging
branch
3 times, most recently
from
d8ec43b
to
e8b9af3
This was referenced Mar 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bbondy commentedMar 3, 2019
•
edited
See here for a description of the task:
Fix #191