Skip to content
This repository has been archived by the owner. It is now read-only.

Temporarily fix https://www.npmjs.com/advisories/803 #206

Merged
merged 2 commits into from Apr 12, 2019
Merged

Conversation

@bsclifton
Copy link
Member

bsclifton commented Apr 12, 2019

Once node-gyp issues a release, we can back this out and update. The version number for that will likely be 3.8.1

More info at: nodejs/node-gyp#1713

@bsclifton bsclifton requested review from diracdeltas and bbondy Apr 12, 2019
@bsclifton bsclifton self-assigned this Apr 12, 2019
@bsclifton
Copy link
Member Author

bsclifton commented Apr 12, 2019

NOTE: looks like CI is failing; will look at this

bsclifton added a commit that referenced this pull request Apr 12, 2019
- Backs out #206
- Updates node-gyp to official build which fixes https://www.npmjs.com/advisories/803
Once `node-gyp` issues a release, we can back this out and update. The version number for that will likely be `3.8.1`

More info at: nodejs/node-gyp#1713
@bsclifton bsclifton force-pushed the bsc-audit-deps branch from 770e7f3 to dc00fcc Apr 12, 2019
I believe this was missed as part of #203
@bsclifton
Copy link
Member Author

bsclifton commented Apr 12, 2019

Fixed 2 malware lists check- there are remaining failures which were caused by #197

@bsclifton bsclifton merged commit bbb9790 into master Apr 12, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bsclifton bsclifton deleted the bsc-audit-deps branch Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.