This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove compatiblity #56
Closed
Conversation
Small but important. Without this, ESLint will not detect ad-block correctly (https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md). Also, Spectron won't launch on macOS.
quanglam2807
changed the title
quanglam2807
changed the title
quanglam2807
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
quanglam2807 commentedMar 24, 2017
•
edited
Add .node to main file path: Small but important. Without this, ESLint will not detect ad-block correctly (https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md). Also, Spectron won't launch on macOS.
Remove preinstall: The packages are included in
dependenciesalready. This script conflicts withelectron-builder. https://ci.appveyor.com/project/webcatalog/webcatalog/build/55. Package stops working with this removal >Update: Add `--ignore-scripts" solve the problems.