This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBlock coin miners by default with Brave shields up #74
+5
−0
Conversation
Testing notes: 1. Close Brave 2. Use new test data file uploaded to the PR. 3. Open Brave 4. Visit https://cnhv.co/6or 5. Turn off shieods Step 4 should not load the page, but if you turn shields down it will.
bbondy
changed the title
|
Agree 100%. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bbondy commentedSep 17, 2017
•
edited
Coin mining in the browser is sometimes abused and can lead to greater CPU usage, especially bad on mobile.
I'm in favour of it.