Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove suspicious exception rules from EP #38
Comments
|
the only thing I can think of is if they are done for webcompat reasons. In which cases it's still preferable to give a mock response instead. |
|
Is there "exclude" filter list in place now to add to, or would it be better to add another step to ingesting in https://github.com/brave/adblock ? |
|
I don't think so but I think we filter some rules from |
|
Okie dokie. I'll talk with @lukemulks about coming up with some sane initial filter-filters. I'll track the list here, and add the functionality into brave/adblock |
There are many exception rules in EP that are suspicious, and allow google analytics, google tag manager, and similar through for unclear reasons:
ex:
We should not respect these cases. We could do this most easily by removing the exception rules in these cases.
@bbondy if the above sounds like an attractive idea, I can work with @lukemulks to come up with some rules to filter these out (meta-filter rules? :P)