Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suspicious exception rules from EP #38

Open
pes10k opened this issue Nov 29, 2018 · 4 comments
Open

Remove suspicious exception rules from EP #38

pes10k opened this issue Nov 29, 2018 · 4 comments

Comments

@pes10k
Copy link
Collaborator

@pes10k pes10k commented Nov 29, 2018

There are many exception rules in EP that are suspicious, and allow google analytics, google tag manager, and similar through for unclear reasons:

ex:

@@||portalbici.es/lib/angulartics-google-analytics/dist/angulartics-ga.min.js
@@||google-analytics.com/analytics.js$domain=tradera.com|xxl.se
@@||google-analytics.com/plugins/ua/ec.js$domain=xxl.se
@@||googletagmanager.com/gtm.js?id=$domain=tradera.com|xxl.se

We should not respect these cases. We could do this most easily by removing the exception rules in these cases.

@bbondy if the above sounds like an attractive idea, I can work with @lukemulks to come up with some rules to filter these out (meta-filter rules? :P)

@bbondy
Copy link
Member

@bbondy bbondy commented Nov 29, 2018

the only thing I can think of is if they are done for webcompat reasons. In which cases it's still preferable to give a mock response instead.
Yes please go ahead.
As with other changes, I'd want this applied via some kind of exclude filter list when parsing.

@pes10k
Copy link
Collaborator Author

@pes10k pes10k commented Nov 29, 2018

Is there "exclude" filter list in place now to add to, or would it be better to add another step to ingesting in https://github.com/brave/adblock ?

@bbondy
Copy link
Member

@bbondy bbondy commented Dec 1, 2018

I don't think so but I think we filter some rules from scripts/generateDataFiles.js

@pes10k
Copy link
Collaborator Author

@pes10k pes10k commented Dec 3, 2018

Okie dokie. I'll talk with @lukemulks about coming up with some sane initial filter-filters. I'll track the list here, and add the functionality into brave/adblock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.