Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new `brave-ads.txt` list #81

Open
fmarier opened this issue Jun 12, 2019 · 2 comments
Open

Create a new `brave-ads.txt` list #81

fmarier opened this issue Jun 12, 2019 · 2 comments

Comments

@fmarier
Copy link
Member

@fmarier fmarier commented Jun 12, 2019

Now that we have entries in brave-unbreak.txt which don't related to unbreaking sites for webcompat reasons, we should have a second list whose name better reflect the purpose of these entries (e.g. brave-ads.txt or just brave.txt).

That way we're transparent about what we're doing and we're not hiding extra blocking rules in a webcompat file.

@pes10k
Copy link
Collaborator

@pes10k pes10k commented Jun 12, 2019

Sounds good to me, though will need to have corresponding changes to https://github.com/brave/ad-block/blob/master/lists/default.h

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jun 13, 2019

Probably gives us time to go through the unbreak list, prune and filters that is in Easylist/Easyprivacy already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.