Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correction latimes.com native ads rules #10

Merged
merged 1 commit into from Mar 4, 2017
Merged

Conversation

@lukemulks
Copy link
Collaborator

lukemulks commented Mar 3, 2017

rule that was submitted and merged was missing a character. all others were correct and are functioning as expected.

rule that has the issue:
||adserve.postrelease.com^$script,image,domain=latimes.com

correct version:
||jadserve.postrelease.com^$script,image,domain=latimes.com

tested in about:adblock, once corrected, it fully resolves.

rule that was submitted and merged was missing a character. all others were correct and are functioning as expected. 

rule that has the issue: 
||adserve.postrelease.com^$script,image,domain=latimes.com

correct version: 
||jadserve.postrelease.com^$script,image,domain=latimes.com

tested in about:adblock, once corrected, it fully resolves.
@lukemulks lukemulks self-assigned this Mar 3, 2017
@lukemulks lukemulks requested a review from bbondy Mar 3, 2017
@bbondy bbondy merged commit f35ddcc into master Mar 4, 2017
@bbondy
Copy link
Member

bbondy commented Mar 4, 2017

++

@lukemulks lukemulks deleted the latimes-native-ads-update-2 branch Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.