Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more admiral servers #277

Closed
wants to merge 2 commits into from
Closed

Add more admiral servers #277

wants to merge 2 commits into from

Conversation

@ryanbr
Copy link
Collaborator

ryanbr commented Nov 9, 2019

Just a sync Admiral server list with Easyprivacy (ios) Just a followup from the previous pull req

#276

@pes10k
Copy link
Collaborator

pes10k commented Nov 9, 2019

@ryanbr maybe it'd be best to make a separate, iOS suplement list? We can bundle that with the next iOS release, and that way other platforms don't get duplicate rules? WDYT?

@ryanbr
Copy link
Collaborator Author

ryanbr commented Nov 9, 2019

When we properly sync with Easyprivacy in slimlist, these rules could be removed.

@pes10k
Copy link
Collaborator

pes10k commented Nov 9, 2019

not necessarily, since its possible slimlist would not come across these domains during its random crawl. So my thinking is that it'd be useful to both have a list of things that were always ship to iOS (and only iOS) regardless of SlimList, for this reason, but also maybe for web compat reasons too

@ryanbr
Copy link
Collaborator Author

ryanbr commented Nov 9, 2019

Yeah, wouldn't be hard to move these rules into its own "admiral list" for slimlist.

@pes10k
Copy link
Collaborator

pes10k commented Nov 9, 2019

Sure, can you create that separate list? And name it something more general, so that we can use it for other similar needs without the same naming problem we got into with brave-unbreak? So something like brave-ios?

@jhreis whats the best way of getting this iOS filter list supplement integrated?

@ryanbr
Copy link
Collaborator Author

ryanbr commented Nov 9, 2019

@ryanbr
Copy link
Collaborator Author

ryanbr commented Feb 7, 2020

PR was superseded by #326

@ryanbr ryanbr closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.