Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix https://github.com/brave/adblock-lists/issues/43 (not being blocked) #295
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanbr commentedNov 24, 2019
•
edited
Visiting
https://3dnews.ru/982615is show the market.yandex widget. With any of the Russian lists enabled in brave://adblock doesn't seem to work when blocking this. I mainly tested Adguard Russian list, but enabling the other Russian lists didn't remove it.In Adguard;
https://filters.adtidy.org/extension/chromium/filters/1.txt(spectiically on https://github.com/AdguardTeam/AdguardFilters/blob/master/RussianFilter/sections/specific.txt#L5635)||aflt.market.yandex.$domain=3dnews.ruThe script we're blocking is
https://aflt.market.yandex.ru/widget/script/apiDoesn't seem to work well in Brave as its not treating everything after the "." as a wildcard. This is a temp fix, but its a bug on our end