Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCosmetic filtering #7
Merged
Conversation
|
Thanks for the PR, looks great overall but I posted some questions in #ads-blocking on Slack. I won't duplicate them here and we'll discuss there. |
antonok-edm
force-pushed the
cosmetic-filtering
branch
2 times, most recently
from
e19e161
to
5eeef6d
add test for class and id stylesheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
antonok-edm commentedAug 29, 2019
Closes #3, depends on brave/adblock-rust#47