Skip to content

/ adblock-rust-ffi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON resources format #8

Merged
merged 1 commit into from Oct 28, 2019
Merged

Support JSON resources format #8

merged 1 commit into from Oct 28, 2019

Conversation

@antonok-edm
Copy link
Collaborator

antonok-edm commented Sep 30, 2019

Required for brave/adblock-rust#50
@antonok-edm antonok-edm requested review from AndriusA and bbondy Sep 30, 2019
@antonok-edm antonok-edm self-assigned this Sep 30, 2019
@AndriusA
AndriusA reviewed Oct 1, 2019
View changes
Copy link
Collaborator

AndriusA left a comment

this bit looks good to me: the JSON-formatted resources are expected to be passed in as a C string
@antonok-edm antonok-edm force-pushed the web_accessible_resources branch from 6aea754 to 5af4fcc Oct 28, 2019
@antonok-edm
support new resources format
Verified
This commit was signed with a verified signature.
antonok-edm Anton Lazarev
GPG key ID: FBD20243E0CD9104 Learn about signing commits
ad40b55
@antonok-edm antonok-edm force-pushed the web_accessible_resources branch from 5af4fcc to ad40b55 Oct 28, 2019
@bbondy
bbondy requested changes Oct 28, 2019
View changes
Copy link
Member

bbondy left a comment

Looks good, but would you mind adding a test with a committed sample test file in examples/cpp/main.cpp? It's a bit weird now but you can run the tests with make sample
@bbondy
bbondy approved these changes Oct 28, 2019
View changes
@bbondy bbondy merged commit 89127a3 into master Oct 28, 2019
@bbondy bbondy mentioned this pull request Nov 12, 2019
Merged
5 of 32 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy

@AndriusA AndriusA

Assignees

@antonok-edm antonok-edm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@antonok-edm @AndriusA @bbondy
You can’t perform that action at this time.