Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove `eprintln!` usage from this library? #88
Comments
|
@AndriusA Hey! I have time over the weekend to work on this. Just tell me how you want it to be done, if at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the following Python code, I call
Engine'sadd_filter_listmethod on the string contents of each downloaded block list.When I run said code on a few popular blocklists, the console is filled with
Filter already exists:Those particular messages come from
src/engine.rs#L166where the library prints to the console in case of an error. I'm personally not a fan of this kind of "logging", since there's no way for me as a consumer of the library to tell it not to print to the console.@AndriusA Do you agree that another method of logging errors should be used? If so, what would be your preferred alternative approach? I'd be happy to make a PR.