Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches Neon dependency to make library Node 12 compatible #21

Merged
merged 1 commit into from Jun 3, 2019
Merged

Conversation

@AndriusA
Copy link
Collaborator

AndriusA commented Jun 3, 2019

@AndriusA AndriusA requested a review from bbondy Jun 3, 2019
@bbondy
bbondy approved these changes Jun 3, 2019
@bbondy bbondy merged commit fe6d79b into master Jun 3, 2019
@bbondy
Copy link
Member

bbondy commented Jun 3, 2019

Realized after merging this doesn't seem to be working:

Caused by:
  failed to load source for a dependency on `neon`

Caused by:
  Unable to update https://github.com/kjvalencik/neon/?branch=node12#5d877ac0

Caused by:
  failed to clone into: /Users/bbondy/.cargo/git/db/neon-4fce05ba4b3c7706

Caused by:
  failed to authenticate when downloading repository
attempted ssh-agent authentication, but none of the usernames `git` succeeded

Caused by:
  ERROR: Repository not found.
; class=Ssh (23); code=Eof (-20)
neon ERR! cargo build failed
@AndriusA AndriusA deleted the node-12 branch Jun 6, 2019
@seeekr
Copy link

seeekr commented Jun 16, 2019

Thanks, using this / your current Cargo.toml makes it work with Node 12!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.