Skip to content

/ adblock-rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter fixes #24

Merged
merged 2 commits into from Jun 4, 2019
Merged

Filter fixes #24

merged 2 commits into from Jun 4, 2019

Conversation

@AndriusA
Copy link
Collaborator

AndriusA commented Jun 4, 2019

Fixes the case with filter tokenisation where ||www.facebook.com/*/plugin does not get picked up when matching https://www.facebook.com/v3.2/plugins/comments.ph

Adds test case to catch regressions if engine tags get dropped when deserialising
AndriusA added 2 commits Jun 4, 2019
@AndriusA
skips last filter token if the filter contains a wildcard
e7cf367
@AndriusA
test ensuring tags are retained after deserializing
541cb11
@AndriusA AndriusA requested a review from bbondy Jun 4, 2019
@bbondy
bbondy approved these changes Jun 4, 2019
View changes
@bbondy bbondy merged commit 093e44e into master Jun 4, 2019
@AndriusA AndriusA deleted the filter-fixes branch Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@AndriusA @bbondy
You can’t perform that action at this time.