Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upchanges tag retention behaviour #26
Merged
Conversation
…not serialize
| ]; | ||
|
|
||
| let mut engine = Engine::from_rules(&filters); | ||
| engine.tags_enable(&["stuff"]); | ||
| engine.tags_enable(&["brian"]); | ||
| let serialized = engine.serialize().unwrap(); | ||
| let mut deserialized_engine = Engine::from_rules(&[]); | ||
| deserialized_engine.tags_enable(&["stuff"]); |
This comment has been minimized.
This comment has been minimized.
AndriusA
Jun 5, 2019
Author
Collaborator
The new engine we'd be restoring to needs to set its own tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AndriusA commentedJun 5, 2019
retain tags of current instance, do not serialize.
when deserializing, tags of the existing instance (the one we are recreating lists into) are maintained