Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplements uBO style polyfills for requests redirects #29
Conversation
|
@snyderp if you review Also added a test that checks parsing extracts all 110 resources for the snapshot of |
|
I think it looks great! Thats a gadzooks for getting this done. One other request; could you update the README.md or similar to show how to use the feature? Or just what end points to use to consume the new resources file? |
| } | ||
| Some(data_url.trim().to_owned()) | ||
| } else { | ||
| // TOOD: handle error - throw? |
This comment has been minimized.
This comment has been minimized.
pes10k
Jun 6, 2019
Collaborator
Could this be logged somehow, even if its just mirroring the "didn't understand filter: X" stuff the current lib does? Would be a nice, noisy reminder if there is some new filter format we don't support, something like that
|
Also, is this exposed through the node API? |
|
@snyderp should we merge and close? It is backwards-compatible, so don't see any harm in that, FFI and browser can be wired up in due course |
|
Yep, looks good to me, though it looks like there are some conflicts now. But I think the change is terrific! |
Make sure deserialization is backwards-comaptible by not deserializing redirect polyfill resources
|
Merged master to resolve conflicts Also to ensure deserialization is backwards compatible have to ignore deserializing of redirect resources for now - included the required changes, tagging @bbondy for review |
|
Switching to MessagePack for serialization to have a cleaner way of adding new fields to blocker structures over time - this works as intended with |
AndriusA commentedJun 6, 2019
returns request content to use for requests matched on rules with
redirectoptionCloses #27