New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds functionality to add filters, check tags #32

Merged

AndriusA merged 1 commit into master from node-api

Jun 12, 2019

+306 −33

Commits on Jun 12, 2019

adds functionality to add filters, check tags

AndriusA committed Jun 12, 2019

- `tagExists` and `clearTags` methods in the Node API
- `addFilter` method in the Node API

About adding filters: rule optimisations that combine rules together make it non-trivial to check whether or not a rule already exists - a rule fused from multiple rules looks very different from the original rule. Checking for existence is therefore only available when optimisations are siwtched off. With optimisations siwtched on, a rule will get added without checking if it already exists

Note the outer-most `Engine` and corresponding Node APIs fail quietly, with only stderr logging in case of errors with existence checking or addition

69e4e47

brave / adblock-rust

adds functionality to add filters, check tags #32

adds functionality to add filters, check tags #32