Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd doc comments for cosmetic filter structs/methods #61
Conversation
This comment has been minimized.
This comment has been minimized.
reeveyoung
commented on 7e10975
Dec 19, 2019
|
Could you give an example how to pass output from hostname_cosmetic_resources() to class_id_stylesheet()? |
|
Should be as simple as this: let resources = engine.hostname_cosmetic_resources("github.com");
let stylesheet = engine.class_id_stylesheet(&["new_class1", "new_class2"], &["new_id1"], resources.exceptions.clone());I'm noticing now that the signature for let resources = engine.hostname_cosmetic_resources("github.com");
let stylesheet = engine.class_id_stylesheet(&["new_class1", "new_class2"], &["new_id1"], &resources.exceptions); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
antonok-edm commentedDec 12, 2019
As per brave/brave-core#3303 (comment) I wanted to make sure it's very clear how the cosmetic filtering interface is to be used.