Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upNetwork filter domain option subsetting #7
Merged
Conversation
…bsetting cases, mirroring uBlock Origin behaviour. I.e. in the case of filter `adv$domain=~example.com|foo.example.com` and request URL = `http://example.net/adv` it does not match when issued from: - http://example.com - http://foo.example.com - http://subfoo.foo.example.com - http://bar.example.com - http://anotherexample.com Closes #5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AndriusA commentedMay 8, 2019
Updates network filter tests to include all permutations of domain subsetting cases, mirroring uBlock Origin behaviour.
I.e. in the case of filter
adv$domain=~example.com|foo.example.comand request URL =http://example.net/advit does not match when issued from:Closes #5