Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd fuzzing using `cargo fuzz`, add test for resulting bug #80
Conversation
|
@AndriusA Should I write more fuzzing targets? |
|
this is a great contribution and one I've been thinking we should do for some time. I just need to look through it properly and fix the bug you've uncovered. If you feel like doing more - great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ArniDagur commentedMar 25, 2020
•
edited
Here I've added a fuzzing harness using
cargo fuzz, along with a fuzzing target forparse_filter. Straight away, a bug was discovered, for which I've added a test case but not a fix: When the stringѤis input to the function, a crash occurs.Ideally we would have a fuzzing target for each function in the crate's public interface, a lot of bugs can be found this way.
Instructions
cargo install cargo-fuzzcargo fuzz run parse_filter