Implements Brave-specific filter options `tag` and `explicitcancel` #9

AndriusA · 2019-05-09T14:34:19Z

Modifies the engine API to accommodate both options:

Engine uses builder pattern to choose which tags should be used
Result structure exposes additional boolean field explicit_cancel to signal when a filter with the option set matches


        Adds support for tag option

To enable rules with a set of tags, you first create an instance of the blocker engine, then add tags: ``` ... let blocker = Engine::from_rules(&rules); engine.with_tags(&["social", "embeds"]); ``` Closes #3


        Implements `explicitcancel` filter option

Returns `explicit_cancel` as a boolean property in the blocker result structure, set to `true` if filter found with no matching exception and the filter specificies `explicitcancel` option. Closes #8

AndriusA added 2 commits May 9, 2019

Adds support for tag option

23ec92f

To enable rules with a set of tags, you first create an instance of the blocker engine, then add tags: ``` ... let blocker = Engine::from_rules(&rules); engine.with_tags(&["social", "embeds"]); ``` Closes #3

Implements `explicitcancel` filter option

4b9301e

Returns `explicit_cancel` as a boolean property in the blocker result structure, set to `true` if filter found with no matching exception and the filter specificies `explicitcancel` option. Closes #8

bbondy approved these changes May 9, 2019

View changes

AndriusA merged commit 033722e into master May 9, 2019

AndriusA deleted the feature-tags branch May 14, 2019

brave / adblock-rust

Implements Brave-specific filter options `tag` and `explicitcancel` #9

Implements Brave-specific filter options `tag` and `explicitcancel` #9

AndriusA commented May 9, 2019

brave / adblock-rust

Join GitHub today

Implements Brave-specific filter options `tag` and `explicitcancel` #9

Implements Brave-specific filter options `tag` and `explicitcancel` #9

Conversation

AndriusA commented May 9, 2019