Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport generichide rules #97
Merged
Conversation
|
looks great! Only spotted an unrelated inaccurate comment |
src/blocker.rs
Outdated
| @@ -1346,14 +1389,13 @@ mod legacy_rule_parsing_tests { | |||
| // easyList = { 24478, 31144, 0, 5589 }; | |||
| // not handling (and not including) filters with the following options: | |||
| // - $popup | |||
| // - $generichide | |||
| // - $subdocument | |||
This comment has been minimized.
This comment has been minimized.
AndriusA
May 22, 2020
Collaborator
not about this PR, but I think we actually do handle $subdocument
This comment has been minimized.
This comment has been minimized.
antonok-edm
May 22, 2020
Author
Collaborator
looks like $document right below is handled too. I'll go ahead and remove both.
This comment has been minimized.
This comment has been minimized.
AndriusA
May 22, 2020
Collaborator
$document only somewhat - there is a spec for handling main document url blocking, but not implemented
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
antonok-edm commentedMay 18, 2020
•
edited
Adds support for
$generichideexception rules (as well as the corresponding uBO-style alias,$ghide). These are network rules that prevent generic cosmetic element hiding from being applied to matching URLs.This partially addresses #1.