Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site settings Autoplay value selector is not showing correctly #10049

Closed
mkarolin opened this issue Jun 2, 2020 · 0 comments
Closed

Site settings Autoplay value selector is not showing correctly #10049

mkarolin opened this issue Jun 2, 2020 · 0 comments
Assignees
@mkarolin
Labels
OS/Desktop QA/Test-Plan-Specified QA/Yes bug regression release-notes/exclude
Projects
General
Milestone
1.10.x - Release

Comments

@mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Jun 2, 2020

Description

Site settings' Autoplay dropdown selector doesn't show any value by default and when clicked "Block" value is not listed, instead there is a blank line.

Steps to Reproduce

  1. Open Brave and navigate to a site, for example, brave.com
  2. Go to Settings -> Privacy and Security -> Site and Shields Settings -> View permissions and data stored across sites
  3. Select site visited in step 1 (brave.com)
  4. Scroll down to Autoplay setting
  5. Notice that the value for Autoplay is empty
  6. Click on the drop down and notice that there are 4 rows instead of 3 and 2 of them are empty.

Actual result:

image

image

Expected result:

The default value is shown:
image

Dropdown shows correct available values:
image

Reproduces how often:

Easily

Brave version (brave://version info)

1.11.41 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:
@mkarolin mkarolin mentioned this issue Jun 2, 2020
Merged
17 of 32 tasks complete
@rebron rebron added this to In progress in General Jun 2, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Jun 2, 2020
@mkarolin
Fixes site settings Autoplay value selector.
Loading status checks…
fa389ac 
Fixes brave/brave-browser#10049

Content settings types list in constants.js is meant to be kept in sync
with chrome/browser/ui/webui/site_settings_helper.cc. We do not patch
the enum in site_settings_helper.cc, but instead override functions that
manipulate it.

On js side we can try to override the behavior, but that may introduce
more patches than just patching the constants.
@mkarolin mkarolin mentioned this issue Jun 2, 2020
Merged
0 of 32 tasks complete
@rebron rebron moved this from In progress to Pending review in General Jun 3, 2020
@bsclifton bsclifton added this to the 1.11.x - Nightly milestone Jun 3, 2020
General automation moved this from Pending review to Completed Jun 3, 2020
@mkarolin mkarolin mentioned this issue Jun 4, 2020
Merged
0 of 32 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop QA/Test-Plan-Specified QA/Yes bug regression release-notes/exclude
Projects
General
  
Completed
Milestone
  1.10.x - Release
Linked pull requests

Successfully merging a pull request may close this issue.

Fixes site settings Autoplay value selector.
2 participants
@bsclifton @mkarolin
You can’t perform that action at this time.