Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] In Private Window with Tor custom theme is not applied #10197

Open
btlechowski opened this issue Jun 10, 2020 · 6 comments
Open

[Desktop] In Private Window with Tor custom theme is not applied #10197

btlechowski opened this issue Jun 10, 2020 · 6 comments

Comments

@btlechowski
Copy link

btlechowski commented Jun 10, 2020

Follow up to #9808 - Brave Custom Theme Install results in visibility issues
In Private Window with Tor Custom Theme is not applied on Linux.

Steps to Reproduce

  1. Clean install
  2. Open Private Window with Tor
  3. Close Private Window with Tor
  4. Install https://chrome.google.com/webstore/detail/pro-grey/enhpebdanojkmhbbneclbkmpleemilaj
  5. Open Private Window with Tor

IMPORTANT: This issue is fixed after browser restart

Actual result:

Custom theme is not applied
image
image

Expected result:

Custom theme should be applied
image
image

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.10.87 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @simonhong @mkarolin

@btlechowski btlechowski changed the title [Desktop] In Private Window with Tor custom theme is not applied on Linux. [Desktop] In Private Window with Tor custom theme is not applied Jun 10, 2020
@btlechowski
Copy link
Author

Just reproduced the issue on Windows

Brave 1.11.58 Chromium: 83.0.4103.61 (Official Build) beta (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Windows 7 Service Pack 1 (Build 7601.24544)

@mkarolin
Copy link
Contributor

cc: @simonhong would you mind taking a look if you have a chance?

@simonhong simonhong self-assigned this Jun 16, 2020
@simonhong
Copy link
Member

@mkarolin Yup, assigned to me :)

@rebron
Copy link
Collaborator

rebron commented Jul 31, 2020

Closing. This is a wontfix. Custom themes should just apply to normal windows. If applied to private window with Tor, users won't be able to differentiate among the windows.

@btlechowski
Copy link
Author

btlechowski commented Aug 3, 2020

@rebron Custom theme on Private Window and Private Window with Tor has already been implemented in #9808. If this is not a desired behavior then we should turn off themes for those windows types.

This issue is just a special case when the theme is not immediately applied after installing the custom theme on Private Window with Tor

@simonhong
Copy link
Member

@btlechowski is right. Currently, custom theme is applied on all windows(including private, tor private).
If we don't want to use custom theme for Tor window, please file an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants