Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad conversions fail after a creative has expired #10240

Open
tmancey opened this issue Jun 12, 2020 · 0 comments · May be fixed by brave/brave-core#5834
Open

Ad conversions fail after a creative has expired #10240

tmancey opened this issue Jun 12, 2020 · 0 comments · May be fixed by brave/brave-core#5834

Comments

@tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 12, 2020

Description

Steps to Reproduce

  1. View an ad (which has a conversion)
  2. Close the browser
  3. Remove the campaign from the catalog

Actual result:

Ad can no longer be converted when visiting the landing page

Expected result:

Ad should be converted when visiting the landing page

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@tmancey tmancey added this to New issues in Ads via automation Jun 12, 2020
@tmancey tmancey moved this from New issues to In progress in Ads Jun 12, 2020
@tmancey tmancey self-assigned this Jun 12, 2020
@tmancey tmancey added the QA/Yes label Jun 12, 2020
@tmancey tmancey moved this from In progress to Review in Ads Jun 13, 2020
@tmancey tmancey removed the OS/Desktop label Jun 13, 2020
@tmancey tmancey linked a pull request that will close this issue Jun 13, 2020
9 of 32 tasks complete
@tmancey tmancey changed the title Ad conversions are lost after a creative expires Ad conversions fail after a creative has expired Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ads
  
Review
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.