Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Brave Icons in Arch #1032

Open
hoggatt opened this issue Sep 8, 2018 · 10 comments
Open

Duplicate Brave Icons in Arch #1032

hoggatt opened this issue Sep 8, 2018 · 10 comments

Comments

@hoggatt
Copy link

hoggatt commented Sep 8, 2018

Description

Clicking on the brave browser (dev) icon creates a duplicate icon in the ubuntu dash (or dock, or panel).

Steps to Reproduce

  1. Install brave-browser-dev on Ubuntu 18.04 following the standard instructions.
  2. Pin "Brave Browser (dev)" to "Favorites"
  3. Click on the icon, a duplicate will show up (see screenshot)

Actual result:

screenshot from 2018-09-07 20-21-12

Expected result:

screenshot from 2018-09-07 20-25-29

Reproduces how often:

Every time

Brave version (about:brave info)

Brave: 0.55.2 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)

Reproducible on current release:

Not if installed through 'snap'

Additional Information

To fix the issue, the following line needs to be added to "/usr/share/applications/Brave Web Browser (dev)":
StartupWMClass=brave-browser

If I add this line, behavior is correct (as seen in the second screenshot).

@srirambv srirambv added this to the 1.x Backlog milestone Sep 8, 2018
@srirambv
Copy link
Contributor

srirambv commented Sep 8, 2018

Possibly duplicate of #713. Only able to add Brave to favourites from apps list overview but doesn't show dev logo shows release version logo.
image

@hoggatt
Copy link
Author

hoggatt commented Sep 14, 2018

For anyone with this problem, the following command fixes it:
sudo sed -i '/Actions=new-window;new-private-window;/a StartupWMClass=brave-browser' /usr/share/applications/brave-browser-dev.desktop

@Kallestofeles
Copy link

Any news on when this might get fixed and pushed to stable release?
Same behavior on Arch linux with brave-bin package (stable) - on gnome it simply creates another icon to the dock/taskbar and the solution is to change the StartupWMClass value in /usr/share/applications/brave-bin.desktop file:
from

StartupWMClass=brave

to

StartupWMClass=brave-browser

@Brave-Matt
Copy link
Collaborator

@TheRoarkster
Copy link

TheRoarkster commented Aug 5, 2019

This is still open, so I wanted to confirm it remains an issue Gnome -- in this case on Manjaro. But the same problem exists:

  1. User cannot add "Brave" to the dock by right clicking because the option to "Add to Favorites" does not display (see here for similar issue);
  2. Adding Brave to dock (by dragging from Gnome "Show Applications") works, but starting Brave leads to a second -- non-system-themed icon at the end of the dock

Oddly, on Manjaro and Arch, if you install the AUR version of Brave, this does not occur.

Note: you can manually fix the issue by following the instructions here.

@fmarier
Copy link
Member

fmarier commented Sep 27, 2019

I've not been able to reproduce this problem on Ubuntu 18.04. I followed the instructions in the bug description and after adding the icon to my favorites, I can start brave by clicking on the icon, but it doesn't create an additional icon as seen in the screenshots.

@lhoggatt17 Are you still seeing this problem if you remove the work-around you added?

@killua99
Copy link

killua99 commented Nov 8, 2019

I can confirm this is still a thing on Manjaro as TheRoarkster did mention. With the steps from before it's fixed.

@stingray21
Copy link

Same for me on Manjaro Gnome. I run this snippet after every update to fix it:

sudo sed -i 's/StartupWMClass=brave/StartupWMClass=brave-browser/g' "/usr/share/applications/brave.desktop"

@thiagola92
Copy link

thiagola92 commented Jul 26, 2020

I am having both issues in Ubuntu 20.04 (Brave Nightly)

  • Only able to add Brave to favorites from apps list overview.
  • Clicking on the brave browser icon creates a duplicate icon in the Ubuntu dash (or dock, or panel).

@fmarier
Copy link
Member

fmarier commented Jul 26, 2020

@thiagola92 If you're using Nightly, then we are tracking that particular issue in #1746 instead. I believe it's only an issue with the Nightly version of Brave at this point.

@fmarier fmarier changed the title Duplicate Brave Icons in Ubuntu (Gnome) Duplicate Brave Icons in Arch Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants