Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block autoplay by default but allow the user to change it #1047

Closed
bbondy opened this issue Sep 9, 2018 · 3 comments
Closed

Block autoplay by default but allow the user to change it #1047

bbondy opened this issue Sep 9, 2018 · 3 comments
Assignees
@darkdh @mkarolin
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes feature/autoplay
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Sep 9, 2018

I think the popup window is too much on each site and can get in the way of browsing. I find it almost as annoying as the autoplay itself. I think just the URL bar thing like widevine is enough.

Putting in 1.x backlog, but I'd love a patch.
@bbondy bbondy added this to the 1.x Backlog milestone Sep 9, 2018
@rebron
Copy link
Collaborator

@rebron rebron commented Sep 9, 2018

Autoplay without sound is on by default in chrome/firefox/safari. We should match that behavior for autoplay without sound.

Example: https://www.simplehuman.com and https://www.tesla.com/models (scroll to mid-page car driving video - range section)
@bbondy
Copy link
Member Author

@bbondy bbondy commented Sep 10, 2018

We'll do the sound only task in the context of #1088
@bbondy bbondy modified the milestones: 1.x Backlog, Releasable builds 0.55.x Sep 10, 2018
@bbondy bbondy added this to Autoplay in 0.55.x - Release Sep 11, 2018
@mkarolin mkarolin self-assigned this Sep 12, 2018
@mkarolin mkarolin mentioned this issue Sep 15, 2018
Merged
7 of 11 tasks complete
@bbondy bbondy removed this from Autoplay in 0.55.x - Release Sep 24, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
@btlechowski
Copy link
Collaborator

@btlechowski btlechowski commented Sep 27, 2018 •
edited by srirambv

Verification passes on

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Windows 7

image

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
@LaurenWags LaurenWags mentioned this issue Jan 17, 2020
Closed
@btlechowski btlechowski mentioned this issue Jan 17, 2020
Closed
78 of 80 tasks complete
@LaurenWags LaurenWags mentioned this issue Jan 17, 2020
Closed
78 of 80 tasks complete
@ChildishGiant ChildishGiant mentioned this issue Jan 19, 2020
Open
@SoaringMoon SoaringMoon mentioned this issue Jan 20, 2020
Closed
This was referenced Jan 21, 2020
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 21, 2020
Closed
@bill-mcgonigle bill-mcgonigle mentioned this issue Jan 21, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jan 21, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Jan 21, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jan 21, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Jan 21, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jan 30, 2020
Closed
This was referenced Jan 31, 2020
Closed
Closed
Open
This was referenced Jan 31, 2020
Closed
Closed
Closed
@chkk525 chkk525 mentioned this issue Feb 1, 2020
Closed
@Gustbel Gustbel mentioned this issue Feb 1, 2020
Closed
@LucaTheHacker LucaTheHacker mentioned this issue Feb 2, 2020
Closed
@srirambv srirambv mentioned this issue Feb 3, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 3, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Feb 3, 2020
Closed
@btlechowski btlechowski mentioned this issue Feb 3, 2020
Closed
This was referenced Feb 3, 2020
Closed
Closed
This was referenced Feb 4, 2020
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Feb 4, 2020
Closed
This was referenced Feb 4, 2020
Open
Closed
@LaurenWags LaurenWags mentioned this issue Feb 4, 2020
Closed
This was referenced Feb 4, 2020
Closed
Closed
@AndriusA AndriusA mentioned this issue Feb 6, 2020
Closed
@mstrcrz mstrcrz mentioned this issue Feb 7, 2020
Open
@MASY2000 MASY2000 mentioned this issue Feb 8, 2020
Closed
@a-bronx a-bronx mentioned this issue Feb 10, 2020
Closed
@qingxiang-jia qingxiang-jia mentioned this issue Feb 10, 2020
Closed
@q3e q3e mentioned this issue Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

@mkarolin mkarolin

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes feature/autoplay
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

Autoplay is blocked by default
7 participants
@bbondy @rebron @darkdh @srirambv @LaurenWags @btlechowski @mkarolin
You can’t perform that action at this time.