Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Widevine in Tor mode #1076

Open
bsclifton opened this issue Sep 10, 2018 · 5 comments
Open

Disable Widevine in Tor mode #1076

bsclifton opened this issue Sep 10, 2018 · 5 comments

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Sep 10, 2018

Carried over from brave/browser-laptop#13626

@bsclifton bsclifton added this to the 1.x Backlog milestone Sep 10, 2018
@tomlowenthal tomlowenthal added this to P3, P4, & P5 Backlog in Tor and Private Windows Oct 30, 2018
@tomlowenthal tomlowenthal moved this from P3, P4, & P5 Backlog to Next up in Tor and Private Windows Nov 7, 2018
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Feb 28, 2019

Still an issue, easiest way to reproduce, see the issue occurring:

You'll notice that you'll get a Widevine notification and can install it inside a Tor Window. Example:

installingwidevinetor

@iefremov
Copy link
Contributor

@iefremov iefremov commented Jul 25, 2019

Blocking the Widevine installation prompt is trivial, we have just to add a check for Tor profile in BraveDrmTabHelper::OnWidevineKeySystemAccessRequest. Do we also have to block playing Widevine videos in Tor windows if Widevine is already installed? @diracdeltas @bsclifton

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jul 25, 2019

i think we should not allow widevine in tor mode even if already installed (same with flash if its installed) but defer to @tomlowenthal

@tomlowenthal
Copy link
Member

@tomlowenthal tomlowenthal commented Jul 25, 2019

I agree with @diracdeltas on this one. My preference is to disable Widevine entirely in Tor: no prompt to install, and no playing if it's already installed.

@iefremov
Copy link
Contributor

@iefremov iefremov commented Jul 25, 2019

No playing goal should be achievable by disabling the content setting for plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.