Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields button pops up when search engine option is shown on omnibox #1097

Open
srirambv opened this issue Sep 11, 2018 · 0 comments
Open

Shields button pops up when search engine option is shown on omnibox #1097

srirambv opened this issue Sep 11, 2018 · 0 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 11, 2018

Description

Shields button pops up when search engine option is shown on omnibox

Steps to Reproduce

  1. Visit a site which has blocked items and shows up on shields badge
  2. Enter search engine keyword and press tab, shows Search on <Webstie> in url omnibox
  3. Shields show up at the end of omnibox with top part of badge cut off.

Actual result:

shield

Expected result:

Should hide the shields behind similar to when typing on the URL bar

Reproduces how often:

Easy

Brave version (about:brave info)

Brave 0.55.2 Chromium: 70.0.3538.12 (Official Build) (64-bit)
Revision ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}
OS Windows

Reproducible on current release:

N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added this to the 1.x Backlog milestone Sep 11, 2018
@bsclifton bsclifton added this to Untriaged Backlog in Shields Oct 30, 2018
@tomlowenthal tomlowenthal moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Shields Nov 6, 2018
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Shields
  
Feature Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.