Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Remove Chromium cookie flyouts #11709

Closed
srirambv opened this issue Sep 14, 2020 · 1 comment · Fixed by brave/brave-core#6642
Closed

[Desktop] Remove Chromium cookie flyouts #11709

srirambv opened this issue Sep 14, 2020 · 1 comment · Fixed by brave/brave-core#6642

Comments

@srirambv
Copy link
Contributor

Description

Remove Chromium cookie flyouts

Steps to Reproduce

  1. Install/Upgrade to 1.16.x nightly
  2. Visit a page
  3. Chromium cookie menu shows up

Actual result:

image
image
image
image
image

Expected result:

Dont show Chromium message

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.16.12 Chromium: 86.0.4240.30 (Official Build) nightly (64-bit)
Revision 09f50eb5535879364cf00e72653462a509ef6bdc-refs/branch-heads/4240@{#552}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Sep 25, 2020

Verified passed with

Brave | 1.15.63 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | macOS Version 10.14.6 (Build 18G3020)

Reproduced the issue as described with 1.16.12 (default settings) using neowin.net:
Screen Shot 2020-09-25 at 10 33 12 AM
Screen Shot 2020-09-25 at 10 33 36 AM
Screen Shot 2020-09-25 at 10 33 51 AM

Visited neowin.net using 1.15.63 (default settings) and there is no Chromium cookie bubble in the URL bar:
Screen Shot 2020-09-25 at 10 35 11 AM

Visited a few other sites, no Chromium cookie bubble on any of them (pinterest.com, slashdot.org, cnn.com).


Verification passed on

Brave 1.15.63 Chromium: 86.0.4240.55 (Official Build) dev (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

Verified test plan from the description.

Visited a few sites, no Chromium cookie bubble on any of them

image


Verification passed on


Brave | 1.15.65 Chromium: 86.0.4240.55 (Official Build) dev (64-bit)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • Verified the STR from the description
  • Verified few sites Buzzfeed.com , Theverge.com and NYtimes in Normal tab, Private tab, Guest window, and Tor windows and ensured that there is no chromium bubble display

Normal Tab
image
image
image

Private Tab
image
image
image

Tor window tab
image
image
image

  • Verified both Dark and Light mode and ensured that there is no chromium cookies bubble display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment