Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to reset Brave Rewards to pre-opt in state #1192

Open
LaurenWags opened this issue Sep 19, 2018 · 17 comments
Open

add ability to reset Brave Rewards to pre-opt in state #1192

LaurenWags opened this issue Sep 19, 2018 · 17 comments

Comments

@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Sep 19, 2018

Description

In browser-laptop we have the ability to delete a wallet and reset Brave Payments to a pre-enabled state (wallet info is removed, publisher info is removed, Brave Payments is turned off). Brave Rewards might benefit from a similar feature.

Steps to Reproduce

(pre-req: have wallet backed up if it contains BAT)

  1. In browser-laptop, with Payments enabled, navigate to the Payments page.
  2. Click on the gear icon.
  3. Click Delete Wallet button.
  4. Click on OK.
  5. Brave Payments is disabled, wallet info is removed from profile, publisher info is removed from profile.
  6. If you re-enable at this point, you get a new wallet.

Actual result:

No way to do this in b-c.

Expected result:

Should be a way to get back to pre opt-in state

Additional Information

Related b-l issues:
brave/browser-laptop#14116 (contains additional items, not just Delete Wallet)
brave/browser-laptop#14758

@bbondy bbondy added this to the 1.x Backlog milestone Sep 22, 2018
@rebron rebron added the priority/P3 label Sep 28, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 1.0 Oct 22, 2018
@NejcZdovc NejcZdovc added this to Backlog in Rewards Oct 30, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@bbondy bbondy moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Rewards Oct 30, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Feb 19, 2019

We're going to need this implemented before the android launch IMO. Reasoning:

Because you won't be able to remove/view any files that are stored on the sandbox storage without rooting, there's really no way of resetting/getting rewards into a working state if a user ends up in a broken state. Their only choice will be to remove the entire app and re-install which isn't the best approach in terms of retention. If you want to access the sandbox storage, you'll need to root the device but this means that reward grants won't work. So it's not really feasible.

We're also getting more reports from users that have run into a state where they can't create wallets due to either having a corrupted ledger_state file or something else that might have happened. There's really no way of correctly recovering unless you start removing files (which we don't recommend doing as it might lead to even more issues) or uninstalling/installing Brave. Again, not great for retention.

This feature should be disconnected from rewards and placed somewhere in Settings. This way, if the entire Rewards feature stops working or gets corrupted, it's still possible to nuke/restart fresh via Settings without relying in the rewards section/code.

CCing @rebron @NejcZdovc @bbondy @bsclifton @LaurenWags @jenn-rhim (design).

@NejcZdovc NejcZdovc self-assigned this Feb 19, 2019
@NejcZdovc NejcZdovc added priority/P2 and removed priority/P3 labels Feb 19, 2019
@NejcZdovc NejcZdovc moved this from P3, P4, & P5 Backlog to P1 & P2 Backlog in Rewards Feb 19, 2019
@NejcZdovc NejcZdovc added this to Nejc in Rewards Team Feb 25, 2019
@rebron rebron added this to Untriaged backlog in Settings Feb 26, 2019
@rebron
Copy link
Collaborator

@rebron rebron commented Feb 26, 2019

cc: @anthonypkeane to put on your radar

@rebron rebron moved this from Untriaged backlog to P1 & P2 Backlog in Settings Feb 26, 2019
@NejcZdovc NejcZdovc removed their assignment Feb 27, 2019
@mandar-brave
Copy link
Collaborator

@mandar-brave mandar-brave commented Mar 4, 2019

Add the feature to reset BR in the "Reset section"

image

Text: "Reset Brave Rewards"
What it does: delete wallet and every other aspect of BR data

@jenn-rhim will create another issue to create BR Settings and separate BR panel in to a separate piece of code that is always accessible.

cc @NejcZdovc @davidtemkin

@NejcZdovc NejcZdovc self-assigned this Mar 5, 2019
@NejcZdovc NejcZdovc added priority/P1 and removed priority/P2 labels Mar 5, 2019
@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Mar 6, 2019

blocked on #926

@NejcZdovc NejcZdovc added the blocked label Mar 6, 2019
@rebron
Copy link
Collaborator

@rebron rebron commented Mar 13, 2019

Screen Shot 2019-03-13 at 2 29 43 PM
Should include a warning/confirm dialog similar to reset settings.

@mandar-brave
Copy link
Collaborator

@mandar-brave mandar-brave commented Apr 2, 2019

On error

Resetting Brave Rewards is failing at the moment. Please restart Brave and try again shortly.

@jasonrsadler

@jasonrsadler
Copy link

@jasonrsadler jasonrsadler commented Apr 2, 2019

@mandar-brave how is this:

Reset Brave Rewards
This will delete your Brave wallet and reset all of your Brave Rewards data, including your earned advertising tokens, contribution history, wallet transaction records, recurring tips to content creators, pending contributions to content creators, and any other Brave Rewards settings you may have saved.

I think we need to specify that wallet will be deleted

jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 2, 2019
Jason Sadler
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 2, 2019
Jason Sadler
Cleanup and test fix
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 2, 2019
Jason Sadler
Cleanup and test fix
@jasonrsadler jasonrsadler moved this from P1 & P2 Backlog to Pending review in Rewards Apr 2, 2019
@jasonrsadler jasonrsadler moved this from Pending review to In Progress in Rewards Apr 2, 2019
@rebron
Copy link
Collaborator

@rebron rebron commented Apr 3, 2019

@mandar-brave @bradleyrichter
Wondering if bullet pointing this list is better. Hard to digest in paragraph form.

Reset Brave Rewards
This will delete your Brave wallet and reset all of your Brave Rewards data, including:

  • your earned advertising tokens
  • contribution history
  • recurring tips to content creators
  • pending contributions to content creators
  • wallet transaction records
    and any other Brave Rewards settings you may have saved.
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Apr 3, 2019

Probably should add a note to backup wallet for future use or reuse?

@jasonrsadler
Copy link

@jasonrsadler jasonrsadler commented Apr 3, 2019

+1 for backup wallet, however, there are certain things like unclaimed advertising tokens ( + all Rewards records, etc.) that would not be recovered. cc @tmancey

@mandar-brave
Copy link
Collaborator

@mandar-brave mandar-brave commented Apr 3, 2019

@rebron open to bullet points; not sure if the visual will look ok. @jasonrsadler i like Raf's proposal, just not sure if the dialog can take than much height and then take the buttons + error. Please comment.

@jasonrsadler
Copy link

@jasonrsadler jasonrsadler commented Apr 3, 2019

@mandar-brave @rebron For the browser 'reset settings'. There is a link for 'Learn More'. Would 'Reset Rewards' detailed explanation be better suited for a help page as well rather than trying to squeeze all in the dialog?

@mandar-brave
Copy link
Collaborator

@mandar-brave mandar-brave commented Apr 3, 2019

@jasonrsadler i can definitely do a FAQ question; knowing the fact that this is nuclear, we should definitely have an upfront "you are warned" thing. Well - tell us what we can squeeze and we can go from there!

jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 3, 2019
Jason Sadler
Cleanup and test fix
@rebron rebron added the support label Apr 4, 2019
@rebron
Copy link
Collaborator

@rebron rebron commented Apr 4, 2019

cc: @Brave-Matt Will need updates to support docs for this one too.

jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 10, 2019
Jason Sadler
Cleanup and test fix
@NejcZdovc NejcZdovc added priority/P3 and removed priority/P1 labels May 22, 2019
@rebron rebron moved this from In progress to P3 backlog in Settings Jun 18, 2019
@rebron rebron added priority/P5 and removed priority/P3 labels Jun 18, 2019
@jsecretan jsecretan moved this from In Progress to Icebox in Rewards Jul 17, 2019
@jasonrsadler jasonrsadler removed their assignment Jul 29, 2019
@rebron rebron moved this from P3 backlog to P5 backlog in Settings Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Rewards
  
Icebox
Settings
P5 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

9 participants
You can’t perform that action at this time.