Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd ability to reset Brave Rewards to pre-opt in state #1192
Comments
|
We're going to need this implemented before the android launch IMO. Reasoning: Because you won't be able to remove/view any files that are stored on the sandbox storage without rooting, there's really no way of resetting/getting rewards into a working state if a user ends up in a broken state. Their only choice will be to remove the entire app and re-install which isn't the best approach in terms of retention. If you want to access the sandbox storage, you'll need to root the device but this means that reward grants won't work. So it's not really feasible. We're also getting more reports from users that have run into a state where they can't create wallets due to either having a corrupted This feature should be disconnected from rewards and placed somewhere in CCing @rebron @NejcZdovc @bbondy @bsclifton @LaurenWags @jenn-rhim (design). |
|
cc: @anthonypkeane to put on your radar |
|
Add the feature to reset BR in the "Reset section" Text: "Reset Brave Rewards" @jenn-rhim will create another issue to create BR Settings and separate BR panel in to a separate piece of code that is always accessible. |
|
blocked on #926 |
|
On error Resetting Brave Rewards is failing at the moment. Please restart Brave and try again shortly. |
|
@mandar-brave how is this: Reset Brave Rewards I think we need to specify that wallet will be deleted |
Cleanup and test fix
Cleanup and test fix
|
@mandar-brave @bradleyrichter Reset Brave Rewards
|
|
Probably should add a note to backup wallet for future use or reuse? |
|
+1 for backup wallet, however, there are certain things like unclaimed advertising tokens ( + all Rewards records, etc.) that would not be recovered. cc @tmancey |
|
@rebron open to bullet points; not sure if the visual will look ok. @jasonrsadler i like Raf's proposal, just not sure if the dialog can take than much height and then take the buttons + error. Please comment. |
|
@mandar-brave @rebron For the browser 'reset settings'. There is a link for 'Learn More'. Would 'Reset Rewards' detailed explanation be better suited for a help page as well rather than trying to squeeze all in the dialog? |
|
@jasonrsadler i can definitely do a FAQ question; knowing the fact that this is nuclear, we should definitely have an upfront "you are warned" thing. Well - tell us what we can squeeze and we can go from there! |
Cleanup and test fix
|
cc: @Brave-Matt Will need updates to support docs for this one too. |
Cleanup and test fix


Description
In browser-laptop we have the ability to delete a wallet and reset Brave Payments to a pre-enabled state (wallet info is removed, publisher info is removed, Brave Payments is turned off). Brave Rewards might benefit from a similar feature.
Steps to Reproduce
(pre-req: have wallet backed up if it contains BAT)
Actual result:
No way to do this in b-c.
Expected result:
Should be a way to get back to pre opt-in state
Additional Information
Related b-l issues:
brave/browser-laptop#14116 (contains additional items, not just Delete Wallet)
brave/browser-laptop#14758