Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide iOS QR Code function in Rewards Settings #12475

Closed
Brave-Matt opened this issue Nov 2, 2020 · 2 comments · Fixed by brave/brave-core#7020
Closed

Hide iOS QR Code function in Rewards Settings #12475

Brave-Matt opened this issue Nov 2, 2020 · 2 comments · Fixed by brave/brave-core#7020

Comments

@Brave-Matt
Copy link
Collaborator

Description

There is confusion surrounding the appearance of the iOS QR code transfer function in the Desktop version of Brave. Given that the feature is not actually operational at this time, the option should be hidden in the desktop version until the feature is actually working.

This will help avoid user confusion surrounding the feature, help avoid additional questions surrounding the feature and why it's being implemented (until the time is right to announce), and help reduce unnecessary support requests.

Miscellaneous Information:

Slack conversation concerning the issue:
https://bravesoftware.slack.com/archives/CKNHM4RTK/p1604089974029400

@Brave-Matt Brave-Matt added this to the 1.16.x - Release #3 milestone Nov 2, 2020
@NejcZdovc NejcZdovc added this to Backlog in Brave Rewards via automation Nov 2, 2020
@NejcZdovc NejcZdovc moved this from Backlog to In progress in Brave Rewards Nov 2, 2020
@bsclifton bsclifton added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 2, 2020
@bsclifton
Copy link
Member

bsclifton commented Nov 2, 2020

This is temporarily hiding the work originally exposed with #12176

This will be re-enabled with #12476 at roughly the same time iOS version 1.22 is released publicly

NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 2, 2020
@NejcZdovc NejcZdovc moved this from In progress to Review in Brave Rewards Nov 2, 2020
bsclifton pushed a commit to brave/brave-core that referenced this issue Nov 3, 2020
Brave Rewards automation moved this from Review to Done Nov 3, 2020
@NejcZdovc NejcZdovc moved this from Done to Waiting Uplift in Brave Rewards Nov 3, 2020
@NejcZdovc NejcZdovc moved this from Waiting Uplift to Done in Brave Rewards Nov 3, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Nov 3, 2020

Verified passed with

Brave | 1.16.72 Chromium: 86.0.4240.183 (Official Build) (x86_64)
-- | --
Revision | 0b568b034b8f7994697cb341eeca5979b84151cc-refs/branch-heads/4240@{#1374}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified test plan from brave/brave-core#7020
Confirmed no QR code box on brave://rewards
Checked clean and upgrade (from 1.16.68) profiles.


Verification passed on

Brave | 1.16.72 Chromium: 86.0.4240.183 (Official Build) (64-bit)
-- | --
Revision | 0b568b034b8f7994697cb341eeca5979b84151cc-refs/branch-heads/4240@{#1374}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

Verified test plan from brave/brave-core#7020
Confirmed no QR code box on brave://rewards
Checked clean and upgrade (from 1.16.68) profiles.
image


Verification passed on

Brave 1.16.72 Chromium: 86.0.4240.183 (Official Build) (64-bit)
Revision 0b568b034b8f7994697cb341eeca5979b84151cc-refs/branch-heads/4240@{#1374}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#7020
Confirmed no QR code box on brave://rewards
Checked clean and upgrade (from 1.16.68) profiles.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants