Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dailymotion doesn't load #1580

Closed
srirambv opened this issue Oct 15, 2018 · 8 comments
Closed

Dailymotion doesn't load #1580

srirambv opened this issue Oct 15, 2018 · 8 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 15, 2018

Description

Dailymotion doesn't load

Steps to Reproduce

  1. Clean profile on 0.55.13
  2. Visit https://dailymotion.com/
  3. Page goes into infinite load and errors our. Stopping page load causes webview crash. (Couldnt capture crash details on Linux)

Actual result:

screenshot from 2018-10-15 11-06-37

Expected result:

Should load the site correctly

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes
  • Does it reproduce on browser-laptop? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No change with shields down. Page still goes into infinite loop
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Found while testing brave/brave-core#599

@srirambv srirambv added this to the 1.x Backlog milestone Oct 15, 2018
@btlechowski
Copy link
Collaborator

@btlechowski btlechowski commented Oct 15, 2018

Reproduced on Windows 7 x64

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7
@srirambv srirambv added the QA/Yes label Oct 15, 2018
@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Oct 15, 2018

Reproduced on macOS 10.12.6 x64

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
@bbondy
Copy link
Member

@bbondy bbondy commented Jan 20, 2019

@srirambv @LaurenWags or @btlechowski (just one), does this still reproduce?

@btlechowski
Copy link
Collaborator

@btlechowski btlechowski commented Jan 21, 2019

Still reproducible.

image

Reproduced on:
Release channel

Brave 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

Beta channel

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows 7

Dev channel

Brave 0.60.15 Chromium: 72.0.3626.53 (Official Build) dev (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7
@Brave-Matt
Copy link
Collaborator

@Brave-Matt Brave-Matt commented Jan 24, 2019

This issue is ongoing, just wanted to note that if you Allow ads/tracers in Shields the site will load and display as intended.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@mrzealot
Copy link

@mrzealot mrzealot commented Feb 19, 2019

Just ran into this during webcompat checks, its problem is how we handle the request to sb.scorecardresearch.com/beacon.js. If we allow, it's fine. If I block it from devtools so that it's "properly" blocked, it's fine again. But the 307 to the empty data URL causes it to go into an infinite loop somehow (didn't dig that far down yet). Not sure if the 200 with empty response would be any better as it'd still think it managed to load it, realize it's bad for some reason, and retry.

@Brave-Matt
Copy link
Collaborator

@Brave-Matt Brave-Matt commented Jun 5, 2019

Wanted to flag this because it's still an easily reproducible issue on all Brave channels (Release channel at v0.64.77 at the time of writing this).
Several users reporting on Community:
https://community.brave.com/t/dailymotion-is-not-working-in-brave/63261/9

Very high traffic/popular site and its worth moving this up in priority/getting eyes on it sooner rather than later. cc @rebron

edit: also wanted to highlight this users findings when troubleshooting:
image

@rebron rebron added this to To do in Web Compatibility via automation Jun 5, 2019
@rebron rebron removed the priority/P4 label Jun 5, 2019
@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jun 6, 2019

Okay, this has required a bit of work to debug, but I believe it has to do with scorecardresearch.com.

Technically the filter /beacon.js should be blocking this. But its not. If the domain scorecardresearch.com is blocked outright it let the site render correctly.
||scorecardresearch.com^$domain=dailymotion.com

ryanbr added a commit to ryanbr/adblock-lists that referenced this issue Jun 6, 2019
@pes10k pes10k added this to Completed in General via automation Jun 6, 2019
Web Compatibility automation moved this from To do to Done Jun 6, 2019
@rebron rebron removed this from Completed in General Jun 19, 2019
@rebron rebron removed this from Done in Web Compatibility Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.