Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installer encounters an error, it goes to an invalid `Help` page #1585

Closed
bsclifton opened this issue Oct 15, 2018 · 2 comments
Closed

When installer encounters an error, it goes to an invalid `Help` page #1585

bsclifton opened this issue Oct 15, 2018 · 2 comments

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 15, 2018

Description

Help button is shown during installer failure. However, when clicked it doesn't go to a working URL

Steps to Reproduce

  1. Download the Brave Beta installer on Windows from https://brave.com/download-beta
  2. Open command line; navigate to directory where installer was downloaded to
  3. Launch installer and pass invalid arguments. Ex: BraveBrowserBetaSetup.exe /q

Actual result:

It navigated to https://updates.bravesoftware.com/support/installer/?hl=&product=&error=0x80040c01&extra_code=0&guver=1.3.101.0&m=0&os=10.0.17134.345&sp=&iid=&brand=&source=gethelp
screen shot 2018-10-15 at 9 17 38 am

Expected result:

It should go to a working URL

Reproduces how often:

100%

Brave version (chrome://version info)

Latest Beta (55.13)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? y
  • Does it reproduce on browser-laptop? n

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a
@bbondy
Copy link
Member

@bbondy bbondy commented Oct 16, 2018

I think Simon fixed this in brave/omaha#6 and I told @mbacchi so he knows about it.

@bbondy bbondy closed this Oct 16, 2018
@bbondy bbondy removed this from Install & Update in 0.55.x - Release Oct 16, 2018
@srirambv srirambv added the OS/Windows label Oct 17, 2018
@btlechowski
Copy link
Collaborator

@btlechowski btlechowski commented Oct 18, 2018

Verification passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

Help points to https://support.brave.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.