Shields is disabled on sites when it's opened in a new background tab

[srirambv]

Description

Shields is disabled on sites when it's opened in a new background tab

Steps to Reproduce

1. Open any GH issue
2. Ctrl+click on any links to open in new tab
3. Switch to the newly opened tabs in background, shields look disabled, can't click on it but shows blocked count
4. Reload page fixes it

Actual result:

Expected result:

Shields should never be disabled unless user disables it

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.25.70 Chromium: 91.0.4472.77 (Official Build) (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Linux

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Maybe not checked
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@iefremov also mentioned he reproduced it but not sure about steps

[GeetaSarvadnya]

Reproduced on Windows 10 x64 - 1.26.55 Chromium: 91.0.4472.88

[srirambv]

Console logs the following error when a tab is open in background.

[1972:1972:0611/082452.532794:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data. Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)
[1972:1972:0611/082452.533031:ERROR:CONSOLE(0)] "Unchecked runtime.lastError: Tabs cannot be edited right now (user may be dragging a tab).", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/_generated_background_page.html (0)

Trying to open dev tools causes shields to be come active again.

[GeetaSarvadnya]

The issue is reproducible in Windows 10 x64 - 1.25.72

[srirambv]

Just a note, this also happens when launching the browser fresh. Sometimes happens with inactive tabs becoming active upon launch

[stephendonner]

Verified PASSED using

Brave	1.27.63 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision	af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS	macOS Version 11.4 (Build 20F71)

Steps:

1. new profile
2. loaded this issue: https://github.com/brave/brave-browser/issues/16362
3. context-clicked on the PR link and chose Open Link in New Tab
4. confirmed the URL loaded
5. confirmed Shields were active and clickable

example	example

---

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.27.63 Chromium: 91.0.4472.101 (Official Build) nightly (64-bit)
--- | --
Revision | af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS | Windows 10 OS Version 2009 (Build 19042.1055)

Quickly went through the case outlined via #16362 (comment) and ensured that loading inactive tabs after a restore correctly displays the shields icon. Uplifting brave/brave-core#9114 & brave/brave-core#9113 as both cases passed.

[GeetaSarvadnya]

Verification passed on

<!--StartFragment-->
Brave | 1.25.73 Chromium: 91.0.4472.106&nbsp;(Official Build)&nbsp;(64-bit)
-- | --
Revision | 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.1052)

<!--EndFragment-->

• Verified the STR from Shields is disabled on sites when it's opened in a new background tab #16362 (comment)
• Verified on both clean and upgraded profile

---

Verification passed on

Brave	1.25.73 Chromium: 91.0.4472.106 (Official Build) (64-bit)
Revision	574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS	Ubuntu 18.04 LTS

• Verified the STR from Shields is disabled on sites when it's opened in a new background tab #16362 (comment)

[oviniciusfeitosa]

Same problem here.

Ubuntu 22.04
Brave Browser 101.1.38.109 

[purefan]

+1 for Ubuntu 22.04 with Brave 1.41.100 Chromium 103.0.5060.132 Official build 64-bit