Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cloud print from Brave #1714

Open
srirambv opened this issue Oct 18, 2018 · 5 comments
Open

Remove Cloud print from Brave #1714

srirambv opened this issue Oct 18, 2018 · 5 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 18, 2018

Description

Remove Cloud print from Brave

Steps to Reproduce

  1. Launch clean profile
  2. Visit brave://net-internals and click on Modules
  3. Cloud Print is listed as a module which we don't use
  4. Cloud print is also listed in clear browsing data modal

Actual result:

image
image

Expected result:

Should not list any option that we don't support out-of-the-box

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @diracdeltas @jumde @bbondy @tomlowenthal

@srirambv srirambv added this to the 1.x Backlog milestone Oct 18, 2018
@tomlowenthal tomlowenthal modified the milestones: 1.x Backlog, 0.56.x - Beta Oct 18, 2018
@tomlowenthal
Copy link
Member

@tomlowenthal tomlowenthal commented Oct 18, 2018

Nice catch. 👌🏻

@pilgrim-brave pilgrim-brave added this to Release 1.0 in Network Audit Oct 18, 2018
@bbondy
Copy link
Member

@bbondy bbondy commented Oct 18, 2018

This extension can be blocked here just like the Chromium PDF Viewer one:
browser/extensions/brave_extension_provider.cc

bool IsBlacklisted(const extensions::Extension* extension) {
  // This is a hardcoded list of extensions to block.
  // Typically instead you can just use the brave/go-updater to list
  // a blacklisted extension that you want to block for existing clients.
  static std::vector<std::string> blacklisted_extensions({
    // Used for tests, corresponds to brave/test/data/should-be-blocked-extension.
    "mlklomjnahgiddgfdgjhibinlfibfffc",
    // Chromium PDF Viewer.
    "mhjfbmdgcfjbbpaeojofohoefgiehjai"
  });
  return std::find(blacklisted_extensions.begin(), blacklisted_extensions.end(),
      extension->id()) != blacklisted_extensions.end();
}
@bbondy bbondy added this to Branding in 0.56.x - Beta Oct 23, 2018
@rebron rebron added this to In progress in General Oct 30, 2018
@rebron rebron removed this from the 0.56.x - Beta milestone Oct 30, 2018
@bbondy bbondy removed this from Branding in 0.56.x - Beta Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@bbondy bbondy moved this from Release 1.0 to P3, P4, & P5 Backlog in Network Audit Oct 30, 2018
@rebron rebron removed this from In progress in General Oct 30, 2018
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@capouch
Copy link

@capouch capouch commented Oct 5, 2019

Would it be possible for someone in the loop to provide a pointer to what's going on with this? I'm pretty inured to cloud printing, and see that there is a reference in the UI to "Brave Cloud" in the print dialog, but it doesn't do anything that I could find.

If there is going to be an analog to Google's product, or an alternative way to do print from the cloud, I'd sure be obliged to have my consciousness raised. I asked a question on the community forum but it's just sitting there. Otherwise it is a productivity threat may drive me back to Chrome.

@jumde
Copy link
Contributor

@jumde jumde commented Oct 9, 2019

Cloud print has been disabled in brave: brave/brave-core@05b501c - @srirambv is there anything else that needs to be done for this issue

@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Oct 9, 2019

@jumde Cloud print is still shown on hosted data in clear data modal. This is on current release build
image

@jumde jumde removed this from P3, P4, & P5 Backlog in Network Audit Oct 9, 2019
@rebron rebron added this to P3 Backlog in General Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
General
  
P3 Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.